Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UserPool resource #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for UserPool resource #2

wants to merge 1 commit into from

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Nov 15, 2024 •
edited
Loading

Issue #1211

Description of changes:

  • Generated UserPool resource
  • Added e2e tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from a-hilaly November 15, 2024 23:30
@ack-prow ACK Prow
Copy link

ack-prow bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 15, 2024
@michaelhtm michaelhtm force-pushed the add-userpool-resource branch 5 times, most recently from 1e61762 to a165933 Compare November 16, 2024 00:53
@michaelhtm
Add support for UserPool resource
b01e337 
* Generated `UserPool` resource
* Added e2e tests
@ack-prow ACK Prow
Copy link

ack-prow bot commented Nov 16, 2024 •
edited
Loading

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cognitoidentityprovider-verify-attribution b01e337 link false /test cognitoidentityprovider-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelhtm